On Mon, Apr 01, 2013 at 02:08:48PM -0700, David Collins wrote:
> Hi,
>
> I am working on a thermal driver which needs to be able to read a
> temperature threshold from a device tree property. The hardware supports
> thresholds in the range -204.8 to +204.7 C in 0.1 C steps. I have found,
> as I am sure others have as well, that dtc treats a '-' before an integer
> in a dtsi file as a syntax error. Therefore, I need some artificial way
> to represent negative numbers in device tree. Here are the possibilities
> that I have thought of so far:
So, as a later posted suggests, dtc does now have integer expression
support, including unary -. The catch is you have to put your
expression in parentheses, so < (-200) > should work where < -200 >
does not. The reason for this is that otherwise something like
<500 -300>
is ambiguous. It could either mean <(500 -300)> == <200> or it could
mean <(500) (-300)>.
It's a bit of a pain, but there's not really any way of fixing it that
doesn't cause more pain along the way.
Well.. while writing that I realised its a bit more complicated. We
could allow negative literals (similar but different in parsing from
unary -). But that causes lexing/parsing problems since then
(500-300) (no spaces) would, without extra fiddling, get lexed as:
"(" LITERAL(500) LITERAL(-300) ")"
whereas the parser would need to see it as
"(" LITERAL(500) "-" LITERAL(300) ")"
So, maybe there's a way but I haven't thought of it yet.
> 1. Use a second integer to specify the sign of the threshold:
> 20000 mC --> <0 20000>
> -20000 mC --> <1 20000>
> 2. Use a string instead of an integer to specify the threshold and
> then convert it to an integer in the driver software:
> 20000 mC --> "20000"
> -20000 mC --> "-20000"
> 3. Use units of millikelvin instead of millicelcius. 0 mC == 273150 mK
> 20000 mC --> <293150>
> -20000 mC --> <253150>
There's always something to be said for using SI units, regardless of
any other considerations.
> 4. Use an arbitrary offset e.g. 0 mC == 1000000
> 20000 mC --> <1020000>
> -20000 mC --> <980000>
> 5. Use the unsigned 32-bit representation for 2’s-compliment
> signed 32-bit integer
> 20000 mC --> <20000>
> -20000 mC --> <0xffffb1e0> or <4294947296>
This is effectively what use of unary - in dtc will do.
> Which of these options would you recommend using? Is there any better way
> to handle negative values that I haven’t listed? What is the best general
> case solution for specifying negative numbers in device tree?
In short both (3) and (5) are reasonable, and dtc will help you with
(5). For the love of god, don't do (1), (2) or (4).
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: Digital signature
