On Sat, Mar 30, 2013 at 05:57:38PM +0800, Ning Jiang wrote: > 2013/3/30 Stephen Boyd <sboyd@xxxxxxxxxxxxxx>: > > On 03/29/13 02:24, ning.n.jiang@xxxxxxxxx wrote: > >> From: Ning Jiang <ning.n.jiang@xxxxxxxxx> > >> > >> Currently there are two problems when we try to stop local timer. > >> First, it calls set_mode function directly so mode state is not > >> updated for the clock event device. Second, it makes the device > >> unused instead of shutdown. > > > > What device is this a problem on? I believe this only matters to drivers > > which enable their timer in their set_next_event() callback? But even > > then, does anything actually happen because the interrupt should have > > been disabled in the local timer stop callback. > > > > Right. Drivers which enable timer in set_next_event() will have this problem. > It will not have functional problem in my case. But my device cannot enter > low power mode with a pending interrupt even if it is disabled. You're not telling us what you have discovered. How does set_next_event() get called after we've set the mode to UNUSED in the current code? -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html