On Sun, Dec 23, 2012 at 11:32:39AM +0000, Will Deacon wrote: > On Fri, Dec 21, 2012 at 10:18:28PM +0000, Pratik Patel wrote: > > What user interface do you plan to provide for the CTI? Maybe > > something consistent with other CoreSight components in sysfs to > > allow users to enable, disable, map and unmap ??? > > > > Please let me know your thoughts. > > Rather than have your current approach of dev nodes + sysfs config files for > each coresight device, I think it might be better to follow something closer > to ftrace and stick per-device directories under debugfs/coresight/. Then you > can have a pipe file and some config files in the same directory for each > component. You also don't need to do any mapping operations with this (just > post-process the stream directly). > Thanks for the suggestion. I had initially debated between debugfs and sysfs but chose sysfs + dev nodes since using device attributes relieves the drivers from manually managing directories and files, its taken care of by the device and sysfs layers. Moreover, since these are physical devices, device attributes made sense at the time. The map and unmap I was referring to was for the CTI trigger mappings. Dev nodes are currently intended to provide the raw data collected in the sinks. Whats the advantage in using debugfs here? > It might also be fun to play with file redirection for sources and sinks, but > that's probably a bit too invasive. > > Will -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
