On 09/26/12 10:35, Pankaj Jangra wrote: > Hi, > > On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: >> In the near future we'll be moving clock-pcom to a platform >> driver, in which case these two users of clk_get() in mach-msm >> need to be updated. Have board-trout-panel.c make the proc_comm >> call directly so that we don't have to port this board specific >> code to the driver right now and reorder the initcall order of >> dma.c so that it initializes after the clock driver probes but >> before any drivers use dma APIs. >> >> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> >> --- >> arch/arm/mach-msm/Makefile | 9 ++++++--- >> arch/arm/mach-msm/board-trout-panel.c | 19 +++++++------------ >> arch/arm/mach-msm/dma.c | 5 ++--- >> 3 files changed, 15 insertions(+), 18 deletions(-) >> >> diff --git a/arch/arm/mach-msm/Makefile b/arch/arm/mach-msm/Makefile >> index 17519fa..3dbae74 100644 >> --- a/arch/arm/mach-msm/Makefile >> +++ b/arch/arm/mach-msm/Makefile >> @@ -5,12 +5,15 @@ obj-$(CONFIG_DEBUG_FS) += clock-debug.o >> obj-$(CONFIG_MSM_VIC) += irq-vic.o >> obj-$(CONFIG_MSM_IOMMU) += devices-iommu.o >> >> -obj-$(CONFIG_ARCH_MSM7X00A) += dma.o irq.o >> -obj-$(CONFIG_ARCH_MSM7X30) += dma.o >> -obj-$(CONFIG_ARCH_QSD8X50) += dma.o sirc.o >> +obj-$(CONFIG_ARCH_MSM7X00A) += irq.o >> +obj-$(CONFIG_ARCH_QSD8X50) += sirc.o >> >> obj-$(CONFIG_MSM_PROC_COMM) += proc_comm.o clock-pcom.o vreg.o >> >> +obj-$(CONFIG_ARCH_MSM7X00A) += dma.o >> +obj-$(CONFIG_ARCH_MSM7X30) += dma.o >> +obj-$(CONFIG_ARCH_QSD8X50) += dma.o >> + > I did not understand what is the need of this change in Makefile? Quoted from commit text: reorder the initcall order of dma.c so that it initializes after the clock driver probes but before any drivers use dma APIs. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
