On Wed, May 02, 2012 at 11:02:25AM +0100, Russell King - ARM Linux wrote: > > > > There is a mux->hw.init = &init missing here. > > What happens to mux->hw.init long term? Because once this function > returns, that pointer will no longer be valid. It's not used after clk_register, so everything should be fine. > It would be a good > idea to NULL it out in clk_register() once its done with, to ensure > that no one comes up with the idea of using it later. Enforcing this is a good idea. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
