On Wed, Apr 11, 2012 at 06:40:24PM +0100, Russell King - ARM Linux wrote: > On Wed, Apr 11, 2012 at 10:38:50AM -0700, Daniel Walker wrote: > > On Wed, Apr 11, 2012 at 05:27:30PM +0100, Russell King - ARM Linux wrote: > > > While here, I propose to delete these: > > > > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[0].start = PHYS_OFFSET; > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[0].node = PHYS_TO_NID(PHYS_OFFSET); > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[0].size = (219*1024*1024); > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[1].start = MSM_HIGHMEM_BASE; > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[1].node = PHYS_TO_NID(MSM_HIGHMEM_BASE); > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[1].size = MSM_HIGHMEM_SIZE; > > > arch/arm/mach-msm/board-sapphire.c: mi->bank[0].start = PHYS_OFFSET; > > > arch/arm/mach-msm/board-sapphire.c: mi->bank[0].node = PHYS_TO_NID(PHYS_OFFSET); > > > arch/arm/mach-msm/board-sapphire.c: mi->bank[0].size = (84*1024*1024); > > > arch/arm/mach-msm/board-sapphire.c: mi->bank[0].size = (101*1024*1024); > > > arch/arm/mach-msm/board-sapphire.c: mi->bank[0].size = (101*1024*1024); > > > > > > because they haven't been buildable since 7th May 2010 (that's 23 months > > > ago), and no one has reported any build errors with them. They're only > > > receiving updates from other sweeps and nothing more. This all means no > > > one is even attempting to build this code. It's pointless having > > > unbuildable code in the kernel, and it's nothing more than a useless > > > maintanence burden. > > > > > > It can't be that hard to fix.. I'll look into cleaning it up. > > What's the point of fixing code which isn't being used by anyone? As I > said above, it's a maintanence burden and if its not being used it needs > to be removed. > Aren't there whole are sub-architectures that don't even build ? I think something that's a work in progress is fine, as long as someone (i.e. me) plans to get back to it at some point. I also said that _I_ would make it build .. So someone is going to use it, and it is going to build. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
