On Tue, Jan 25 2011, Daniel Walker wrote: > On Tue, 2011-01-25 at 13:52 -0800, Saravana Kannan wrote: >> On 01/25/2011 01:38 PM, Daniel Walker wrote: >> > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote: >> >> Remove dead code and push out clock-7x30.h and clock-pcom.h to >> >> where they are actually used. >> >> >> > >> > I'd do two patches for this. The stuff your doing is too disconnected. >> > >> > Daniel >> > >> There is a whole bunch of unused code in the clock files and it's being >> deleted. I don't see a point of splitting it up per file. > > It's easier to review when changes aren't merged that don't related to > each other. In this particular case, the patch is a bunch of removal of dead code, and kind of makes sense to keep it together. I'm fine with it as is. David Brown -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html