Re: [PATCH 0/7] Nexus One Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 22 Jan 2011, Brian Swetland wrote:

> All we ask is that some reasonable acknowledgement of original
> authorship is maintained for non-trivial work.  A 5-10 line patch that
> deals with mechanical issues of board files or cleans stuff up is no
> big deal.  100s of lines that represent some real work is something
> else.

So... What about http://article.gmane.org/gmane.linux.ports.arm.msm/167 ?
Is that good enough for you?  If no, then could you please propose an 
alternative?  If that is indeed good enough, then could we please move on?

> What would be useful would be a reasonable convention for
> acknowledging multiple authors, perhaps something along the lines of:
> 
> Author: Awesome Upstreamer <au@xxxxxxxxxxx>  or  Main Author <main@xxxxxxxxxxx>
> Committer: Awesome Upstreamer <au@xxxxxxxxxxx>
> Subject: arm: msm8k: acpu clock management
> 
> ... summary of the patch ...
> 
> Original-Author: Joe Firmware Guy <joe@xxxxxxx>
> Original-Author: Kernel Droid <droid@xxxxxxxxxxx>
> Signed-off-by: ...
> 
> Though I'm not sure "Original-Author" is the best phrasing here...  Or
> perhaps just having the patch description end with "This patch is
> based on original code by Joe Firmware Guy, Kernel Droid, etc is the
> way to go.  I do think that for work where there is one clear original
> author, it's nice to leave them as the Author, but at the end of the
> day, provided the code's heading in the right direction and the
> contributors are acknowledged, that's a detail.

I think a free form list of contributors in the commit log should be 
fine, possibly adding them in CC to the patch submission as well.

There is a _huge_ value in the action of making code palatable for 
mainline inclusion and actually pushing that code into mainline. If you 
do it yourself next time instead of letting your code rot then no one 
might be tempted to stump on your authorship.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux