On 01/19/2011 02:50 AM, Vitaly Wool wrote:
Hi,
On Tue, Jan 18, 2011 at 7:14 PM, Daniel Walker<dwalker@xxxxxxxxxxxxxx> wrote:
The probe function adds the MMC host which can start accepting request
immediately. There is an assumption here that no requests happen
immediatly, but it's not always the case. This assumption can causes
a BUG() when the clocks are disabled. The fix is to just remove the
clock disable in the probe function.
Signed-off-by: Daniel Walker<dwalker@xxxxxxxxxxxxxx>
I can add acked-by and/or tested-by if needed.
~Vitaly
Nack from me. The fix is incorrect. The clocks are alread refcounted in
the clock driver. There should be no need to "leave it on because
someone else might access it". Every code that needs the clock should
have a clk_enable/disable around it and it would all work fine.
-Saravana
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
