Re: [PATCH v5 5/5] msm: add SMP support for msm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 15, 2010 at 10:54:16PM -0800, Jeff Ohlstein wrote:
> +void __cpuinit platform_secondary_init(unsigned int cpu)
> +{
> +	/* Configure edge-triggered PPIs */
> +	writel(GIC_PPI_EDGE_MASK, MSM_QGIC_DIST_BASE + GIC_DIST_CONFIG + 4);

At some point we should really clean this up so we don't have code
writing directly to the GIC registers like this.

> +static __init void prepare_cold_cpu(unsigned int cpu)
> +{
> +	int ret;
> +	ret = scm_set_boot_addr((void *)
> +				virt_to_phys(msm_secondary_startup),

It seems wrong to cast a physical address to a pointer - physical
addresses should not be pointer-like.  Can it stay as an integer?

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux