+ spin_lock_irqsave(&tlmm_lock, irq_flags); + for_each_set_bit(i, msm_gpio.enabled_irqs, NR_GPIO_IRQS) { + if (!test_bit(i, msm_gpio.wake_irqs)) + writel(TARGET_PROC_NONE, GPIO_INTR_CFG_SU(i)); + }If none of the enabled irqs is configured as a wakeup source, should not we disable the summary IRQ?
I do not believe there is a need. If no irqs are wakeup sources, then the summary irq is also not a wakeup source, see msm_gpio_irq_set_wake(). And if the GIC will mask the TLMM block appropriately during system PM without further bit-twiddling from me, why complicate my PM hooks further? -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
