Hi Gregory,
On Fri, Nov 12, 2010 at 10:09:01AM -0800, Gregory Bean wrote:
> Beginning with the MSM8x60, the hardware block responsible for gpio
> support changes. Provide gpiolib support for the new v2 architecture.
>
> Signed-off-by: Gregory Bean <gbean@xxxxxxxxxxxxxx>
> ---
[snip]
> +static inline void clr_gpio_bits(unsigned n, void __iomem *reg)
> +{
> + writel(readl(reg) & ~n, reg);
IMO you should move the locking here. And since the only user of this function
is msm_gpio_direction_input, I'd eliminate it altogether.
> +}
[snip]
> +static int msm_gpio_direction_input(struct gpio_chip *chip, unsigned
> offset)
> +{
> + unsigned long irq_flags;
> +
> + spin_lock_irqsave(&tlmm_lock, irq_flags);
> + clr_gpio_bits(BIT(GPIO_OE_BIT), GPIO_CONFIG(offset));
> + spin_unlock_irqrestore(&tlmm_lock, irq_flags);
> + return 0;
> +}
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
