On Fri, Oct 29, 2010 at 03:21:22PM -0700, Daniel Walker wrote: > On Fri, 2010-10-29 at 23:14 +0100, Russell King - ARM Linux wrote: > > > Your original patch is unsuitable as it leaves the values uninitialized. > > > > All I'm really concerned about is fixing the build issue during this > merge window. But I'll send another patch with your suggestions added. As we have had a complaint from Linus about pointless churn, and this approach causes unnecessary churn, I will refuse to apply this. Fix the thing properly (it's not hard) or don't bother trying to fix it at all. All you need do is to use your initial patch, but change the addruart to the following: .macro addruart, rp, rv mov rv, #0xff000000 orr rv, rv, #0x00f00000 .endm and you commit the result. Problem fixed in one go, both from the compile point of view _and_ the runtime point of view. It's really not difficult. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
