Hi Neil, On 8/28/2010 3:48 AM, Neil Leeder wrote: > + __set_bit(EV_KEY, context->qcikbd_dev->evbit); > + __set_bit(EV_REP, context->qcikbd_dev->evbit); If you are going to roll out new version of this patch to address the last comment from Dmitry, then I have couple of suggestions. If possible then please incorporate. Make EV_REP optional, not all the systems needs it by default. Better to introduce pdata->rep. Some of the systems would need each key press to wake up the system, so disable_irq in suspend would not be what they want. How about introducing pdata->wakeup flag and then using device_init_wakeup, device_may_wakeup, enable/disable_irq_wake friends in probe and .suspend/.resume functions. ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
