On Mon, 2010-08-30 at 17:18 -0700, Gregory Bean wrote: > + /* printk("%s %08x %08x bit %d gpio %d irq %d\n", > + __func__, v, m, j, msm_chip->chip.start + j, > + FIRST_GPIO_IRQ + msm_chip->chip.start + j); */ > Can you drop everything that's un-used .. There's also the enter/exit sleep functions, which I'm pretty sure aren't used. Also break this into two patches one for gpio and another for the interrupt component .. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html