Hi!
> Needed to get the driver to compile ;(
>
> Signed-off-by: Daniel Walker <dwalker@xxxxxxxxxxxxxx>
> ---
> include/linux/msm_mdp.h | 86 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 86 insertions(+), 0 deletions(-)
> create mode 100644 include/linux/msm_mdp.h
>
> + MDP_RGB_565, // RGB 565 planer
planar? Also avaoid C++ comments here.
> + MDP_XRGB_8888, // RGB 888 padded
> + MDP_Y_CBCR_H2V2, // Y and CbCr, pseudo planer w/ Cb is in MSB
> + MDP_ARGB_8888, // ARGB 888
> + MDP_RGB_888, // RGB 888 planer
> + MDP_Y_CRCB_H2V2, // Y and CrCb, pseudo planer w/ Cr is in MSB
> + MDP_YCRYCB_H2V1, // YCrYCb interleave
> + MDP_Y_CRCB_H2V1, // Y and CrCb, pseduo planer w/ Cr is in MSB
> + MDP_Y_CBCR_H2V1, // Y and CrCb, pseduo planer w/ Cr is in> MSB
misaligned?
> + MDP_RGBA_8888, // ARGB 888
> + MDP_BGRA_8888, // ARGB 888
really?
> +struct mdp_rect {
> + uint32_t x;
> + uint32_t y;
> + uint32_t w;
> + uint32_t h;
> +};
Better just use u32. And u32 x,y,w,h; would be quite enough.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
