On Thu, Nov 14, 2024 at 07:44:32PM +0000, Suravee Suthikulpanit wrote: > Also, the set_dte_entry() is used to program several DTE fields (e.g. > stage1 table, stage2 table, domain id, and etc.), which is difficult > to keep track with current implementation. > > Therefore, separate logic for clearing DTE (i.e. make_clear_dte) and > another function for setting up the GCR3 Table Root Pointer, GIOV, GV, > GLX, and GuestPagingMode into another function set_dte_gcr3_table(). > > Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx> > --- > drivers/iommu/amd/amd_iommu.h | 2 + > drivers/iommu/amd/amd_iommu_types.h | 13 +-- > drivers/iommu/amd/init.c | 30 ++++++- > drivers/iommu/amd/iommu.c | 129 ++++++++++++++++------------ > 4 files changed, 106 insertions(+), 68 deletions(-) Got lost on v10: Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Jason