Re: [PATCH v3 18/18] scsi: target: iscsi: switch to using the crc32c library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Eric Biggers <ebiggers@xxxxxxxxxx>
Subject: Re: [PATCH v3 18/18] scsi: target: iscsi: switch to using the crc32c library
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 04 Nov 2024 20:33:47 -0500
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, Ard Biesheuvel <ardb@xxxxxxxxxx>
In-reply-to: <20241103223154.136127-19-ebiggers@kernel.org> (Eric Biggers's message of "Sun, 3 Nov 2024 14:31:54 -0800")
Organization: Oracle Corporation
References: <20241103223154.136127-1-ebiggers@kernel.org> <20241103223154.136127-19-ebiggers@kernel.org>

Eric,

> Now that the crc32c() library function directly takes advantage of
> architecture-specific optimizations, it is unnecessary to go through
> the crypto API. Just use crc32c(). This is much simpler, and it
> improves performance due to eliminating the crypto API overhead.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH v3 00/18] Wire up CRC32 library functions to arch-optimized code
  - From: Eric Biggers
- [PATCH v3 18/18] scsi: target: iscsi: switch to using the crc32c library
  - From: Eric Biggers

Prev by Date: Re: [PATCH v7 6/8] x86/module: prepare module loading for ROX allocations of text
Next by Date: Re: [f2fs-dev] [PATCH v3 17/18] f2fs: switch to using the crc32 library
Previous by thread: [PATCH v3 18/18] scsi: target: iscsi: switch to using the crc32c library
Next by thread: [PATCH v3 16/18] jbd2: switch to using the crc32c library
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]