On Sat, 2 Nov 2024 at 10:45, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > > > While testing this patchset I notice that none of the crypto API drivers for > > crc32 or crc32c even need to be loaded on my system anymore, as everything on my > > system that uses those algorithms (such as ext4) just uses the library APIs now. > > That makes the "check /proc/crypto" trick stop working anyway. > > What's stopping us from removing them altogether? > At least btrfs supports a variety of checksums/hashes (crc32c, xxhash, sha) via the shash API. There are some other remaining uses of crc32c using shash or sync ahash where the algo is hardcoded (NVMe, infiniband) so I imagine those might be candidates for conversion as well.
