On 22/10/2024 19:15, Dave Hansen wrote: > On 10/22/24 08:11, Kevin Brodsky wrote: >>>> +#define PKEY_UNRESTRICTED 0x0 >>>> #define PKEY_DISABLE_ACCESS 0x1 >>>> #define PKEY_DISABLE_WRITE 0x2 >>>> #define PKEY_ACCESS_MASK (PKEY_DISABLE_ACCESS |\ >>> It seems sane, but it would be nice to have at least site or two use it >>> in the kernel so show that it's useful in practice. Is there any kernel >>> code or anything in selftests/ that would be improved with this? >> As a matter of fact this would improve the readability of [1] quite a >> bit: all those set_pkey_bits(..., 0) calls would become >> set_pkey_bits(..., PKEY_UNRESTRICTED). I'm sure other pkey-related >> kselftests could benefit too. > It would be much appreciated if someone could make a pass over kernel > code and fix up the places where PKEY_UNRESTRICTED makes things more clear. It doesn't look like kernel code would have a use for it at the moment, but I have found a few places in kselftests (mm, ppc) where 0 could be replaced with PKEY_UNRESTRICTED. I can send a follow-up series. Kevin
