Re: [PATCH v10 1/5] rust: add static_branch_unlikely for static_key_false

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
Subject: Re: [PATCH v10 1/5] rust: add static_branch_unlikely for static_key_false
From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
Date: Fri, 11 Oct 2024 21:48:32 +0200
Cc: Gary Guo <gary@xxxxxxxxxxx>, Alice Ryhl <aliceryhl@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Jason Baron <jbaron@xxxxxxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, Miguel Ojeda <ojeda@xxxxxxxxxx>, Alex Gaynor <alex.gaynor@xxxxxxxxx>, Wedson Almeida Filho <wedsonaf@xxxxxxxxx>, Boqun Feng <boqun.feng@xxxxxxxxx>, Björn Roy Baron <bjorn3_gh@xxxxxxxxxxxxxx>, Benno Lossin <benno.lossin@xxxxxxxxx>, Andreas Hindborg <a.hindborg@xxxxxxxxxx>, linux-trace-kernel@xxxxxxxxxxxxxxx, rust-for-linux@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, linux-arch@xxxxxxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Sean Christopherson <seanjc@xxxxxxxxxx>, Uros Bizjak <ubizjak@xxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Oliver Upton <oliver.upton@xxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Ryan Roberts <ryan.roberts@xxxxxxx>, Fuad Tabba <tabba@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Anup Patel <apatel@xxxxxxxxxxxxxxxx>, Andrew Jones <ajones@xxxxxxxxxxxxxxxx>, Alexandre Ghiti <alexghiti@xxxxxxxxxxxx>, Conor Dooley <conor.dooley@xxxxxxxxxxxxx>, Samuel Holland <samuel.holland@xxxxxxxxxx>, linux-riscv@xxxxxxxxxxxxxxxxxxx, Huacai Chen <chenhuacai@xxxxxxxxxx>, WANG Xuerui <kernel@xxxxxxxxxx>, Bibo Mao <maobibo@xxxxxxxxxxx>, Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Tianrui Zhao <zhaotianrui@xxxxxxxxxxx>, loongarch@xxxxxxxxxxxxxxx
In-reply-to: <CABCJKue7qT9drhgrXPEjBO=gPw79vYELAZxz747Z8WMF=vj2MQ@mail.gmail.com>
References: <20241011-tracepoint-v10-0-7fbde4d6b525@google.com> <20241011-tracepoint-v10-1-7fbde4d6b525@google.com> <20241011131316.5d6e5d10@eugeo> <CABCJKuesYQWvfScFaqv_rW5ZqAJNn4zK9iOFAmyTaYKO3S5hgw@mail.gmail.com> <20241011171251.0bd53f01@eugeo> <CABCJKue7qT9drhgrXPEjBO=gPw79vYELAZxz747Z8WMF=vj2MQ@mail.gmail.com>

On Fri, Oct 11, 2024 at 7:52 PM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
>
> It's just one line per helper, but sure, I do see your point.

I guess we will have a lot of helpers added over time, so even if it
is one line, it may end up being a lot of lines in total. The rules
should stay constant, which would be better. Having said that, it is
true the extra complexity of the rules isn't great either.

Cheers,
Miguel

Follow-Ups:
- Re: [PATCH v10 1/5] rust: add static_branch_unlikely for static_key_false
  - From: Sami Tolvanen

References:
- [PATCH v10 0/5] Tracepoints and static branch in Rust
  - From: Alice Ryhl
- [PATCH v10 1/5] rust: add static_branch_unlikely for static_key_false
  - From: Alice Ryhl
- Re: [PATCH v10 1/5] rust: add static_branch_unlikely for static_key_false
  - From: Gary Guo
- Re: [PATCH v10 1/5] rust: add static_branch_unlikely for static_key_false
  - From: Sami Tolvanen
- Re: [PATCH v10 1/5] rust: add static_branch_unlikely for static_key_false
  - From: Gary Guo
- Re: [PATCH v10 1/5] rust: add static_branch_unlikely for static_key_false
  - From: Sami Tolvanen

Prev by Date: Re: [PATCH v6 33/33] kselftest/riscv: kselftest for user mode cfi
Next by Date: Re: [RFC PATCH 3/4] mm: madvise: implement lightweight guard page mechanism
Previous by thread: Re: [PATCH v10 1/5] rust: add static_branch_unlikely for static_key_false
Next by thread: Re: [PATCH v10 1/5] rust: add static_branch_unlikely for static_key_false
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]