Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h
From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Date: Wed, 09 Oct 2024 12:04:10 +0200
Cc: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, "Jason A . Donenfeld" <Jason@xxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Naveen N Rao <naveen@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
In-reply-to: <87wmihr49g.ffs@tglx>
References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> <87wmihr49g.ffs@tglx>

On Wed, Oct 09 2024 at 11:53, Thomas Gleixner wrote:
> On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote:

Hit send too early.

>> +#if defined(CONFIG_PHYS_ADDR_T_64BIT)
>> +#define PAGE_MASK	(~((1 << CONFIG_PAGE_SHIFT) - 1))

This really wants a comment. The magic reliance on integer sign
expansion is any thing than obvious.

Thanks,

         tglx

Follow-Ups:
- Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h
  - From: Vincenzo Frascino
- Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h
  - From: Michael Ellerman

References:
- [PATCH v3 0/2] vdso: Use only headers from the vdso/ namespace
  - From: Vincenzo Frascino
- [PATCH v3 2/2] vdso: Introduce vdso/page.h
  - From: Vincenzo Frascino
- Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h
  - From: Thomas Gleixner

Prev by Date: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h
Next by Date: Re: [PATCH v15 09/19] tracing: Add ftrace_fill_perf_regs() for perf event
Previous by thread: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h
Next by thread: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]