On Fri, Aug 30, 2024 at 02:04:39PM +0200, Jason A. Donenfeld wrote: > > > +SYM_FUNC_START(__arch_chacha20_blocks_nostack) > > Is there any way we can reuse the existing code in > > crypto/chacha-neon-core.S for this? It looks to my untrained eye like > > this is an arbitrarily different implementation to what we already have. > Nope, it is indeed different, and not arbitrarily so. This patch is > mirroring exactly what we did on x86. It's probably worth some comments or something explaining what's going on with that (the commit log for the x86 patch mentions that it's that the vDSO needs a version that doesn't write to the stack).
Attachment:
signature.asc
Description: PGP signature