On 12/06/2024 21:02, Arnd Bergmann wrote: > On Wed, Jun 12, 2024, at 18:00, Steven Price wrote: >> The macro set_fixmap_offset_io() was added in commit f774b7d10e21 >> ("arm64: fixmap: fix missing sub-page offset for earlyprintk") but then >> commit 8ef0ed95ee04 ("arm64: remove arch specific earlyprintk") removed >> the file causing the only user to be removed when the two commits were >> merged. Since this has never been used again since the v3.15 release >> remove it. >> >> Signed-off-by: Steven Price <steven.price@xxxxxxx> >> --- >> This came up because for Arm CCA there is a need to override >> set_fixmap_io() [1] and rather than also update set_fixmap_offset_io() I >> thought it would be better to just drop the unused macro. >> >> [1] https://lore.kernel.org/lkml/20240605093006.145492-6-steven.price@xxxxxxx/ > > I assume you want to keep this with your other patch, so > > Acked-by: Arnd Bergmann <arnd@xxxxxxxx> Actually for now it looks[1] like we're going to drop the overriding of set_fixmap_io() so if you want to apply this change separately please do! Thanks, Steve [1] https://lore.kernel.org/r/b611bb5f-b6f8-44a4-9b33-a92862974363%40arm.com