On Sat, Jun 08, 2024 at 08:38:12AM +0900, Akira Yokosawa wrote: > On 2024/06/05 13:02, Paul E. McKenney wrote: > > On Wed, Jun 05, 2024 at 10:57:27AM +0900, Akira Yokosawa wrote: > >> On Tue, 4 Jun 2024 15:14:19 -0700, Paul E. McKenney wrote: > >>> Add a citation to Marco's LF mentorship session presentation entitled > >>> "The Kernel Concurrency Sanitizer" > >>> > >>> [ paulmck: Apply Marco Elver feedback. ] > >>> > >>> Reported-by: Marco Elver <elver@xxxxxxxxxx> > >>> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx> > >>> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > >>> Cc: Andrea Parri <parri.andrea@xxxxxxxxx> > >>> Cc: Will Deacon <will@xxxxxxxxxx> > >>> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > >>> Cc: Boqun Feng <boqun.feng@xxxxxxxxx> > >>> Cc: Nicholas Piggin <npiggin@xxxxxxxxx> > >>> Cc: David Howells <dhowells@xxxxxxxxxx> > >>> Cc: Jade Alglave <j.alglave@xxxxxxxxx> > >>> Cc: Luc Maranget <luc.maranget@xxxxxxxx> > >>> Cc: Akira Yokosawa <akiyks@xxxxxxxxx> > >> > >> Paul, > >> > >> While reviewing this, I noticed that > >> tools/memory-model/Documentation/README has no mention of > >> access-marking.txt. > >> > >> It has no mention of glossary.txt or locking.txt, either. > >> > >> I'm not sure where are the right places in README for them. > >> Can you update it in a follow-up change? > >> > >> Anyway, for this change, > >> > >> Reviewed-by: Akira Yokosawa <akiyks@xxxxxxxxx> > > > > Thank you, and good catch! Does the patch below look appropriate? > > Well, I must say this is not what I expected. > Please see below. OK, I was clearly in way too much of a hurry when doing this, and please accept my apologies for my inattention. I am therefore going to do what I should have done in the first place, which is to ask you if you would like to send a patch fixing this. If so, I would be quite happy to replace mine with yours. Thanx, Paul > > ------------------------------------------------------------------------ > > > > commit 834b22ba762fb59024843a64554d38409aaa82ec > > Author: Paul E. McKenney <paulmck@xxxxxxxxxx> > > Date: Tue Jun 4 20:59:35 2024 -0700 > > > > tools/memory-model: Add access-marking.txt to README > > > > Given that access-marking.txt exists, this commit makes it easier to find. > > > > Reported-by: Akira Yokosawa <akiyks@xxxxxxxxx> > > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx> > > > > diff --git a/tools/memory-model/Documentation/README b/tools/memory-model/Documentation/README > > index db90a26dbdf40..304162743a5b8 100644 > > --- a/tools/memory-model/Documentation/README > > +++ b/tools/memory-model/Documentation/README > > @@ -47,6 +47,10 @@ DESCRIPTION OF FILES > > README > > This file. > > > > +access-marking.txt > > + Guidelines for marking intentionally concurrent accesses to > > + shared memory. > > + > > cheatsheet.txt > > Quick-reference guide to the Linux-kernel memory model. > > > > What I expected was an entry in the bullet list in the upper half > of README which mentions access-marking.txt along with the update of > alphabetical list of files. > > Updating the latter wouldn't worth bothering you. > > And you are missing another comment WRT glossary.txt and locking.txt. ;-) > > Let me suggest an idea of their positions in the bullet list where the > ordering is important. Looks reasonable to you ? > > o simple.txt > o ordering.txt > o locking.txt <--new > o litmus-test.txt > o recipes.txt > o control-dependencies.txt > o access-marking.txt <--new > o cheatsheet.txt > o explanation.txt > o references.txt > o glossary.txt <--new > > Have I made my point clear enough? > > Thanks, Akira
