Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Pavel Begunkov <asml.silence@xxxxxxxxx>
Subject: Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 5 Jun 2024 01:24:19 -0700
Cc: Mina Almasry <almasrymina@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Donald Hunter <donald.hunter@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Andreas Larsson <andreas@xxxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Steffen Klassert <steffen.klassert@xxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, David Ahern <dsahern@xxxxxxxxxx>, Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, Christian König <christian.koenig@xxxxxxx>, David Wei <dw@xxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Yunsheng Lin <linyunsheng@xxxxxxxxxx>, Shailend Chand <shailend@xxxxxxxxxx>, Harshitha Ramamurthy <hramamurthy@xxxxxxxxxx>, Shakeel Butt <shakeel.butt@xxxxxxxxx>, Jeroen de Borst <jeroendb@xxxxxxxxxx>, Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>
In-reply-to: <5aee4bba-ca65-443c-bd78-e5599b814a13@gmail.com>
References: <20240530201616.1316526-1-almasrymina@google.com> <20240530201616.1316526-3-almasrymina@google.com> <ZlqzER_ufrhlB28v@infradead.org> <CAHS8izMU_nMEr04J9kXiX6rJqK4nQKA+W-enKLhNxvK7=H2pgA@mail.gmail.com> <5aee4bba-ca65-443c-bd78-e5599b814a13@gmail.com>

On Mon, Jun 03, 2024 at 03:52:32PM +0100, Pavel Begunkov wrote:
> The question for Christoph is what exactly is the objection here? Why we
> would not be using well defined ops when we know there will be more
> users?

The point is that there should be no more users.  If you need another
case you are doing something very wrong.

Follow-Ups:
- Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers
  - From: Pavel Begunkov

References:
- [PATCH net-next v10 00/14] Device Memory TCP
  - From: Mina Almasry
- [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers
  - From: Mina Almasry
- Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers
  - From: Christoph Hellwig
- Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers
  - From: Mina Almasry
- Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers
  - From: Pavel Begunkov

Prev by Date: Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers
Next by Date: Re: [PATCH v3 cmpxchg 4/4] ARM: Emulate one-byte cmpxchg
Previous by thread: Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers
Next by thread: Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]