On Sat, May 11, 2024, at 16:28, Huacai Chen wrote: > On Sat, May 11, 2024 at 8:17 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: >> Importantly, we can't just add fstatat64() on riscv32 because >> there is no time64 version for it other than statx(), and I don't >> want the architectures to diverge more than necessary. >> I would not mind adding a variant of statx() that works for >> both riscv32 and loongarch64 though, if it gets added to all >> architectures. > > As far as I know, Ren Guo is trying to implement riscv64 kernel + > riscv32 userspace, so I think riscv32 kernel won't be widely used? I was talking about the ABI, so it doesn't actually matter what the kernel is: any userspace ABI without CONFIG_COMPAT_32BIT_TIME is equally affected here. On riscv32 this is the only allowed configuration, while on others (arm32 or x86-32 userland) you can turn off COMPAT_32BIT_TIME on both 32-bit kernel and on 64-bit kernels with compat mode. Arnd