On Mon, Mar 11, 2024 at 12:24:24PM -0700, Ian Rogers wrote: > 5) headers we have just so we can use shell scripts to scrape > constants for beautifying things in perf trace > (5) feels like the headers should be alongside the shell scripts to > avoid polluting tools/include. > Not that I propose fixing any of this here. Yeah, 5 is why we have things used just for scrapping in tools/perf/trace/beauty/include/, that now has just socket.h, used by ⬢[acme@toolbox perf-tools-next]$ tools/perf/trace/beauty/socket.sh | head static const char *socket_ipproto[] = { [0] = "IP", [1] = "ICMP", [2] = "IGMP", [4] = "IPIP", [6] = "TCP", [8] = "EGP", [12] = "PUP", [17] = "UDP", [22] = "IDP", ⬢[acme@toolbox perf-tools-next]$ I'll see if I get a series moving things that are just for scrapping to that directory, then test on the container build images I have. - Arnaldo