Re: [PATCH v4 05/12] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Williams <dan.j.williams@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v4 05/12] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal
From: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
Date: Thu, 8 Feb 2024 17:09:08 -0500
Cc: linux-kernel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, linux-arch@xxxxxxxxxxxxxxx, linux-cxl@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>
In-reply-to: <65c549aa701cb_afa42943d@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com> <20240208184913.484340-6-mathieu.desnoyers@efficios.com> <65c549aa701cb_afa42943d@dwillia2-xfh.jf.intel.com.notmuch>
User-agent: Mozilla Thunderbird

On 2024-02-08 16:37, Dan Williams wrote:
[...]

+DEFINE_FREE(cleanup_dax, struct dax_dev *, if (!IS_ERR_OR_NULL(_T)) virtio_fs_cleanup_dax(_T))


This IS_ERR_OR_NULL is ok because dax_dev is initialized to NULL, but
maybe this could just be IS_ERR() and then initialize @dax_dev to
ERR_PTR(-EOPNOTSUPP)?


Done.

Mathieu


--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com

References:
- [PATCH v4 00/12] Introduce cpu_dcache_is_aliasing() to fix DAX regression
  - From: Mathieu Desnoyers
- [PATCH v4 05/12] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal
  - From: Mathieu Desnoyers
- RE: [PATCH v4 05/12] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal
  - From: Dan Williams

Prev by Date: Re: [PATCH v4 04/12] dcssblk: Handle alloc_dax() -EOPNOTSUPP failure
Next by Date: Re: [PATCH v4 06/12] dax: Check for data cache aliasing at runtime
Previous by thread: RE: [PATCH v4 05/12] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal
Next by thread: [PATCH v4 09/12] nvdimm/pmem: Cleanup alloc_dax() error handling
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]