On Wed, Jan 24, 2024 at 01:43:55PM -0600, Sam Protsenko wrote: > On Wed, Jan 24, 2024 at 4:40 AM Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote: > > Using fifo_lvl_mask works but is wrong on multiple levels. > > As the code is now, the device tree spi alias is used as an index in the > > fifo_lvl_mask to determine the FIFO depth. I find it unacceptable to > > have a dependency on an alias in a driver. Not specifying an alias will > > make the probe fail, which is even worse. Also, the fifo_lvl_mask value > Ok, I think that's a valid point. I probably missed the alias part > when reading the patch description. I also understand we can't just > remove .fifo_lvl_mask right now, as we have to keep the compatibility > with older/existing out-of-tree device trees, so that the user can > update the kernel image separately. I don't really agree here, for a given compatible the FIFO depth is known so it's redundant to specify and it's much simpler to correct issues if we're not overspecifying things in the DT.
Attachment:
signature.asc
Description: PGP signature
