On Wed, Dec 06, 2023 at 11:10:45AM +0000, David Laight wrote: > Do we? > I've not seen any justification for this at all. > IIRC the ICMPv4 reply code needs the checksum function return 0xffff > for all-zero input. > > So the correct and simple fix is to initialise the sum to 0xffff > in the checksum function. You do realize that ICMPv4 reply code is not the only user of those, right? Sure, we can special-case it there. And audit the entire call tree, proving that no other call chains need the same. Care to post the analysis? I have the beginnings of that and it's already long and convoluted and touches far too many places, all of which will have to be watched indefinitely, so that changes in there don't introduce new breakage. I could be wrong. About many things, including the depth of your aversion to RTFS. But frankly, until that analysis shows up somewhere, I'm going to ignore your usual handwaving.
