On Fri, 2023-12-01 at 15:43 +0100, Arnd Bergmann wrote: > On Fri, Dec 1, 2023, at 13:16, Philipp Stanner wrote: > > > > -#ifdef CONFIG_PCI > > /** > > You should not remove the #ifdef here, it probably results in > a build failure when CONFIG_GENERIC_PCI_IOMAP is set and > GENERIC_PCI is not. CONFIG_PCI you mean. Yes, that results in a build failure. That's what the Intel bots have reminded me of subtly before, which is why I: > > Alternatively you could use Kconfig or Makefile logic to > prevent the file from being built without CONFIG_PCI. did exactly that in this very patch: @@ -14,6 +14,7 @@ ifdef CONFIG_PCI <------------ obj-$(CONFIG_PROC_FS) += proc.o obj-$(CONFIG_SYSFS) += slot.o obj-$(CONFIG_ACPI) += pci-acpi.o +obj-$(CONFIG_GENERIC_PCI_IOMAP) += iomap.o <----------- endif P. > > Arnd >
