On Fri, Dec 1, 2023, at 13:16, Philipp Stanner wrote: > The pcim_*() functions in lib/devres.c are guarded by an #ifdef > CONFIG_PCI and, thus, don't belong to this file. They are only ever used > for pci and are not generic infrastructure. > > Move all pcim_*() functions in lib/devres.c to drivers/pci/devres.c. > Adjust the Makefile. > > Suggested-by: Danilo Krummrich <dakr@xxxxxxxxxx> > Signed-off-by: Philipp Stanner <pstanner@xxxxxxxxxx> > --- > drivers/pci/Makefile | 2 +- > drivers/pci/devres.c | 207 ++++++++++++++++++++++++++++++++++++++++++ > lib/devres.c | 208 +------------------------------------------ I still think this should go into drivers/pci/pci_iomap.c along with the other functions. Arnd