Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Mina Almasry <almasrymina@xxxxxxxxxx>
Subject: Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Fri, 10 Nov 2023 15:19:19 -0800
Cc: netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linaro-mm-sig@xxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, David Ahern <dsahern@xxxxxxxxxx>, Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, "Christian König" <christian.koenig@xxxxxxx>, Shakeel Butt <shakeelb@xxxxxxxxxx>, Jeroen de Borst <jeroendb@xxxxxxxxxx>, Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>, Willem de Bruijn <willemb@xxxxxxxxxx>, Kaiyuan Zhang <kaiyuanz@xxxxxxxxxx>
In-reply-to: <20231106024413.2801438-11-almasrymina@google.com>
References: <20231106024413.2801438-1-almasrymina@google.com> <20231106024413.2801438-11-almasrymina@google.com>

On Sun,  5 Nov 2023 18:44:09 -0800 Mina Almasry wrote:
> +		if (!skb_frags_not_readable(skb)) {

nit: maybe call the helper skb_frags_readable() and flip
     the polarity, avoid double negatives.

References:
- [RFC PATCH v3 00/12] Device Memory TCP
  - From: Mina Almasry
- [RFC PATCH v3 10/12] tcp: RX path for devmem TCP
  - From: Mina Almasry

Prev by Date: Re: [RFC PATCH v3 02/12] net: page_pool: create hooks for custom page providers
Next by Date: Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags
Previous by thread: Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP
Next by thread: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]