On Tue, Sep 12, 2023, at 09:48, Thomas Zimmermann wrote: > Clean up and rename fb_pgprotect() to work without struct file. Then > refactor the implementation for PowerPC. This change has been discussed > at [1] in the context of refactoring fbdev's mmap code. > > The first two patches update fbdev and replace fbdev's fb_pgprotect() > with pgprot_framebuffer() on all architectures. The new helper's stream- > lined interface enables more refactoring within fbdev's mmap > implementation. > > Patches 3 to 5 adapt PowerPC's internal interfaces to provide > phys_mem_access_prot() that works without struct file. Neither the > architecture code or fbdev helpers need the parameter. > > v4: > * fix commit message (Christophe) > v3: > * rename fb_pgrotect() to pgprot_framebuffer() (Arnd) I had another look today, and everything look good to me now. Whole series Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>