From: Ying Sun <sunying@xxxxxxxxxxxxxx> The macro of “cpumask_of_node(node)” in line 49 is a dead code which will never be implemented，because its conditions of line 30 "#ifndef CONFIG_NUMA" and line 48 "#ifdef CONFIG_NUMA" are mutually exclusive. It is recommended to delete redundant code. Suggested-by: Yanjie Ren <renyanjie01@xxxxxxxxx> Signed-off-by: Ying Sun <sunying@xxxxxxxxxxxxxx> --- include/asm-generic/topology.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/include/asm-generic/topology.h b/include/asm-generic/topology.h index 4dbe715be65b..8fcc95953e70 100644 --- a/include/asm-generic/topology.h +++ b/include/asm-generic/topology.h @@ -45,11 +45,7 @@ #endif #ifndef cpumask_of_node - #ifdef CONFIG_NUMA - #define cpumask_of_node(node) ((node) == 0 ? cpu_online_mask : cpu_none_mask) - #else - #define cpumask_of_node(node) ((void)(node), cpu_online_mask) - #endif + #define cpumask_of_node(node) ((void)(node), cpu_online_mask) #endif #ifndef pcibus_to_node #define pcibus_to_node(bus) ((void)(bus), -1) @@ -61,7 +57,7 @@ cpumask_of_node(pcibus_to_node(bus))) #endif -#endif /* CONFIG_NUMA */ +#endif /* !CONFIG_NUMA */ #if !defined(CONFIG_NUMA) || !defined(CONFIG_HAVE_MEMORYLESS_NODES) -- 2.17.1
