On Mon, Jul 10, 2023 at 04:17:27PM -0700, Andrew Morton wrote:
> On Mon, 10 Jul 2023 21:43:05 +0100 "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> wrote:
> > +static inline struct address_space *folio_flush_mapping(struct folio *folio)
> > +{
> > + if (unlikely(folio_test_swapcache(folio)))
> > + return NULL;
> > +
> > + return folio_mapping(folio);
> > +}
>
> The name makes it sound like it flushes something. Wouldn't
> folio_flushable_mapping() be clearer?
Yes; I wasn't a big fan of the name, but I wasn't a fan of perpetuating
the page_file_mapping / page_mapping_file confusio either. Do you want
me to send you a set of fixup patches, or will you run them through sed
-i ? ;-)
