On Sun, Jun 11, 2023 at 03:57:32PM +0800, Baoquan He wrote: > On 06/11/23 at 08:40am, Mike Rapoport wrote: > > Hi Baoquan, > > > > On Sat, Jun 10, 2023 at 04:26:21PM +0800, Baoquan He wrote: > > > On 06/09/23 at 07:09pm, kernel test robot wrote: > > > > Hi Baoquan, > > > > > > > > kernel test robot noticed the following build errors: > > > > > > > > [auto build test ERROR on akpm-mm/mm-everything] > > > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/asm-generic-iomap-h-remove-ARCH_HAS_IOREMAP_xx-macros/20230609-160014 > > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > > > patch link: https://lore.kernel.org/r/20230609075528.9390-3-bhe%40redhat.com > > > > patch subject: [PATCH v6 02/19] hexagon: mm: Convert to GENERIC_IOREMAP > > > > config: hexagon-randconfig-r041-20230608 (https://download.01.org/0day-ci/archive/20230609/202306091859.NhlW2nny-lkp@xxxxxxxxx/config) > > > > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > > > > reproduce (this is a W=1 build): > > > > mkdir -p ~/bin > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > > chmod +x ~/bin/make.cross > > > > git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git > > > > git fetch akpm-mm mm-everything > > > > git checkout akpm-mm/mm-everything > > > > b4 shazam https://lore.kernel.org/r/20230609075528.9390-3-bhe@xxxxxxxxxx > > > > # save the config file > > > > mkdir build_dir && cp config build_dir/.config > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=hexagon olddefconfig > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=hexagon prepare > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > > the same patch/commit), kindly add following tags > > > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202306091859.NhlW2nny-lkp@xxxxxxxxx/ > > > > > > Thanks for reporting. I reproduced them on my local machine. Below patch > > > can fix them. And by the way, I also saw the clone3 warning, and have to > > > made change in scripts/checksyscalls.sh to mute it, wondering how you > > > handle it in your testing. > > > > I think the warning kbuild reported is rather this one: > > > > >> include/asm-generic/io.h:1078:6: error: conflicting types for 'iounmap' > > 1078 | void iounmap(volatile void __iomem *addr); > > | ^ > > This one is reported as error. The old iounmap() declaration has a const, > while the standard one doesn't have. So I just remove the old one to use > the standard one. > > Another one is warning about PCI_IOBASE. Because inb/w/l and outb/w/l is > redefined in asm-generic/io.h, and it uses PCI_IOBASE which is defniend > as NULL in asm-generic/io.h if ARCH doesn't have its own PCI_IOBASE > definition. Then the warning is triggered. So I define macro to override > the standard inb/w/l and outb/w/l. > > #ifndef PCI_IOBASE > #define PCI_IOBASE ((void __iomem *)0) > #endif I believe that this series [1] by Niklas Schnelle should take care of the PCI_IOBASE warnings (which are not Hexagon specific), so there is no need to worry about them when they show up in build reports. [1]: https://lore.kernel.org/20230522105049.1467313-1-schnelle@xxxxxxxxxxxxx/ Cheers, Nathan > > > stdin>:1520:2: warning: syscall clone3 not implemented [-W#warnings] > > > 1520 | #warning syscall clone3 not implemented > > > | ^ > > > 1 warning generated. > > > > > > ------ > > > diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh > > > index 1e5d2eeb726d..3a369b78edb7 100755 > > > --- a/scripts/checksyscalls.sh > > > +++ b/scripts/checksyscalls.sh > > > @@ -148,6 +148,7 @@ cat << EOF > > > #define __IGNORE_nanosleep > > > #define __IGNORE_io_getevents > > > #define __IGNORE_recvmmsg > > > +#define __IGNORE_clone3 > > > #endif > > > > > > > > > From 6a86f4360a61a2b7b4d71172e5c03be554367553 Mon Sep 17 00:00:00 2001 > > > From: root <root@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > Date: Fri, 9 Jun 2023 21:21:36 -0400 > > > Subject: [PATCH] hexagon: mm: fix warning in asm/io.h > > > Content-type: text/plain > > > > > > Remove the old iounmap() declaration which is not consistent with the > > > standard one in asm-generic/io.h, let's use the standard one. > > > > > > And also add macro definition of inb/w/l and outb/w/l to override > > > the definition of them in asm-generic/io.h. > > > > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > Signed-off-by: Baoquan He <bhe@xxxxxxxxxx> > > > --- > > > arch/hexagon/include/asm/io.h | 8 ++++++-- > > > scripts/checksyscalls.sh | 1 + > > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h > > > index dcd9cbbf5934..efe9cb00ebf8 100644 > > > --- a/arch/hexagon/include/asm/io.h > > > +++ b/arch/hexagon/include/asm/io.h > > > @@ -27,8 +27,6 @@ > > > extern int remap_area_pages(unsigned long start, unsigned long phys_addr, > > > unsigned long end, unsigned long flags); > > > > > > -extern void iounmap(const volatile void __iomem *addr); > > > - > > > /* Defined in lib/io.c, needed for smc91x driver. */ > > > extern void __raw_readsw(const void __iomem *addr, void *data, int wordlen); > > > extern void __raw_writesw(void __iomem *addr, const void *data, int wordlen); > > > @@ -207,16 +205,19 @@ static inline void memset_io(volatile void __iomem *addr, int value, > > > * > > > * Operates on "I/O bus I/O space" > > > */ > > > +#define inb inb > > > static inline u8 inb(unsigned long port) > > > { > > > return readb(_IO_BASE + (port & IO_SPACE_LIMIT)); > > > } > > > > > > +#define inw inw > > > static inline u16 inw(unsigned long port) > > > { > > > return readw(_IO_BASE + (port & IO_SPACE_LIMIT)); > > > } > > > > > > +#define inl inl > > > static inline u32 inl(unsigned long port) > > > { > > > return readl(_IO_BASE + (port & IO_SPACE_LIMIT)); > > > @@ -227,16 +228,19 @@ static inline u32 inl(unsigned long port) > > > * @data: data to write to > > > * @addr: address in I/O space > > > */ > > > +#define outb outb > > > static inline void outb(u8 data, unsigned long port) > > > { > > > writeb(data, _IO_BASE + (port & IO_SPACE_LIMIT)); > > > } > > > > > > +#define outw outw > > > static inline void outw(u16 data, unsigned long port) > > > { > > > writew(data, _IO_BASE + (port & IO_SPACE_LIMIT)); > > > } > > > > > > +#define outl outl > > > static inline void outl(u32 data, unsigned long port) > > > { > > > writel(data, _IO_BASE + (port & IO_SPACE_LIMIT)); > > > > > > > -- > > Sincerely yours, > > Mike. > > > >
