Re: [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx>
Subject: Re: [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()
From: Dave Hansen <dave.hansen@xxxxxxxxx>
Date: Thu, 25 May 2023 12:18:34 -0700
Cc: kirill.shutemov@xxxxxxxxxxxxxxx, Dexuan Cui <decui@xxxxxxxxxxxxx>, ak@xxxxxxxxxxxxxxx, arnd@xxxxxxxx, bp@xxxxxxxxx, brijesh.singh@xxxxxxx, dan.j.williams@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, haiyangz@xxxxxxxxxxxxx, hpa@xxxxxxxxx, jane.chu@xxxxxxxxxx, kys@xxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, luto@xxxxxxxxxx, mingo@xxxxxxxxxx, peterz@xxxxxxxxxxxxx, rostedt@xxxxxxxxxxx, sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx, seanjc@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, tony.luck@xxxxxxxxx, wei.liu@xxxxxxxxxx, x86@xxxxxxxxxx, mikelley@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Tianyu.Lan@xxxxxxxxxxxxx
In-reply-to: <20230525190812.bz5hg5k3uaibtcys@box>
References: <20230504225351.10765-1-decui@microsoft.com> <20230504225351.10765-3-decui@microsoft.com> <9e466079-ff27-f928-b470-eb5ef157f048@intel.com> <20230523223750.botogigv6ht7p2zg@box.shutemov.name> <2d96a23f-a16a-50e1-7960-a2d4998ce52f@intel.com> <20230523232851.a3djqxmpjyfghbvc@box.shutemov.name> <20230525190812.bz5hg5k3uaibtcys@box>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 5/25/23 12:08, Kirill A. Shutemov wrote:
> Shared->Private conversion is rare. I only see one call total during the
> boot in my setup. Worth fixing anyway.
...
> Any comments?

So the rules are:

 * Shared mapping of a private page: BAD
 * Private mapping of a shared page: OK

?

The patch seems OK, other than having zero comments in it.

References:
- [PATCH v6 0/6] Support TDX guests on Hyper-V
  - From: Dexuan Cui
- [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()
  - From: Dexuan Cui
- Re: [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()
  - From: Dave Hansen
- Re: [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()
  - From: kirill . shutemov
- Re: [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()
  - From: Dave Hansen
- Re: [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()
  - From: kirill . shutemov
- Re: [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()
  - From: Kirill A. Shutemov

Prev by Date: Re: [PATCH v2 13/34] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor}
Next by Date: Re: [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()
Previous by thread: Re: [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()
Next by thread: [PATCH v6 3/6] x86/hyperv: Add hv_isolation_type_tdx() to detect TDX guests
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]