[RFC PATCH 0/3] Prohibit irq disable when disabled or enable when enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Any thoughts on tightening this up and adding some warnings for this?
Motivated by a bug I added to powerpc which broke disabled-disable
callers.

Not that I necessarily want archs to be able to depend on this, it
would always be better to be tolerant. But it seems a risky pattern
for random code to be using.

This still fires off quite a few warnings on powerpc, and I haven't
test booted any other arch so probably wouldn't ask to upstream patch
3 just yet, but if there are no objections to the idea I might do a
bit more work on it.

Thanks,
Nick

Nicholas Piggin (3):
  hrtimer: balance irq save/restore
  init: Require archs call start_kernel with arch irqs disabled
  irqflags: Warn on irq disable when disabled and enable when enabled

 include/linux/irqflags.h       | 26 ++++++++++++++++++++++++--
 init/main.c                    |  6 +++++-
 kernel/locking/irqflag-debug.c | 14 ++++++++++++++
 kernel/time/hrtimer.c          | 22 +++++++++++-----------
 4 files changed, 54 insertions(+), 14 deletions(-)

-- 
2.40.1




[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux