On Tue, Mar 21, 2023 at 12:25:12PM +0000, Mark Rutland wrote: > +static void assert_clear_valid(struct kunit *test, > + const struct usercopy_params *params, > + const char *dst, long dst_offset, > + unsigned long ret) > +{ > + const unsigned long size = params->size; > + const unsigned long offset = params->offset; Nit: long offset. Otherwise, Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>