Re: [Patch v4 06/13] x86/hyperv: Change vTOM handling to use standard coco mechanisms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Michael Kelley (LINUX)" <mikelley@xxxxxxxxxxxxx>
Subject: Re: [Patch v4 06/13] x86/hyperv: Change vTOM handling to use standard coco mechanisms
From: Borislav Petkov <bp@xxxxxxxxx>
Date: Mon, 9 Jan 2023 19:07:33 +0100
Cc: "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, KY Srinivasan <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, "wei.liu@xxxxxxxxxx" <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, "luto@xxxxxxxxxx" <luto@xxxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "davem@xxxxxxxxxxxxx" <davem@xxxxxxxxxxxxx>, "edumazet@xxxxxxxxxx" <edumazet@xxxxxxxxxx>, "kuba@xxxxxxxxxx" <kuba@xxxxxxxxxx>, "pabeni@xxxxxxxxxx" <pabeni@xxxxxxxxxx>, "lpieralisi@xxxxxxxxxx" <lpieralisi@xxxxxxxxxx>, "robh@xxxxxxxxxx" <robh@xxxxxxxxxx>, "kw@xxxxxxxxx" <kw@xxxxxxxxx>, "bhelgaas@xxxxxxxxxx" <bhelgaas@xxxxxxxxxx>, "arnd@xxxxxxxx" <arnd@xxxxxxxx>, "hch@xxxxxxxxxxxxx" <hch@xxxxxxxxxxxxx>, "m.szyprowski@xxxxxxxxxxx" <m.szyprowski@xxxxxxxxxxx>, "robin.murphy@xxxxxxx" <robin.murphy@xxxxxxx>, "thomas.lendacky@xxxxxxx" <thomas.lendacky@xxxxxxx>, "brijesh.singh@xxxxxxx" <brijesh.singh@xxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, Tianyu Lan <Tianyu.Lan@xxxxxxxxxxxxx>, "kirill.shutemov@xxxxxxxxxxxxxxx" <kirill.shutemov@xxxxxxxxxxxxxxx>, "sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx" <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>, "ak@xxxxxxxxxxxxxxx" <ak@xxxxxxxxxxxxxxx>, "isaku.yamahata@xxxxxxxxx" <isaku.yamahata@xxxxxxxxx>, "dan.j.williams@xxxxxxxxx" <dan.j.williams@xxxxxxxxx>, "jane.chu@xxxxxxxxxx" <jane.chu@xxxxxxxxxx>, "seanjc@xxxxxxxxxx" <seanjc@xxxxxxxxxx>, "tony.luck@xxxxxxxxx" <tony.luck@xxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-hyperv@xxxxxxxxxxxxxxx" <linux-hyperv@xxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, "linux-arch@xxxxxxxxxxxxxxx" <linux-arch@xxxxxxxxxxxxxxx>, "iommu@xxxxxxxxxxxxxxx" <iommu@xxxxxxxxxxxxxxx>
In-reply-to: <BYAPR21MB16889518EB304B1A95FE7D22D7FE9@BYAPR21MB1688.namprd21.prod.outlook.com>
References: <1669951831-4180-1-git-send-email-mikelley@microsoft.com> <1669951831-4180-7-git-send-email-mikelley@microsoft.com> <Y7xDDNMIDyHKLicG@zn.tnic> <BYAPR21MB16889518EB304B1A95FE7D22D7FE9@BYAPR21MB1688.namprd21.prod.outlook.com>

On Mon, Jan 09, 2023 at 05:37:00PM +0000, Michael Kelley (LINUX) wrote:
> OK.  I have no objection to putting that code in a separate "helper"
> function.  The only slight messiness is that the helper function must
> be separately wrapped in #ifdef CONFIG_AMD_MEM_ENCRYPT, or
> marked __maybe_unused.

I'd vote for __maybe_unused as that doesn't mean more ifdeffery.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

References:
- [Patch v4 00/13] Add PCI pass-thru support to Hyper-V Confidential VMs
  - From: Michael Kelley
- [Patch v4 06/13] x86/hyperv: Change vTOM handling to use standard coco mechanisms
  - From: Michael Kelley
- Re: [Patch v4 06/13] x86/hyperv: Change vTOM handling to use standard coco mechanisms
  - From: Borislav Petkov
- RE: [Patch v4 06/13] x86/hyperv: Change vTOM handling to use standard coco mechanisms
  - From: Michael Kelley (LINUX)

Prev by Date: Re: [Patch v4 07/13] swiotlb: Remove bounce buffer remapping for Hyper-V
Next by Date: Re: [Patch v4 00/13] Add PCI pass-thru support to Hyper-V Confidential VMs
Previous by thread: RE: [Patch v4 06/13] x86/hyperv: Change vTOM handling to use standard coco mechanisms
Next by thread: [Patch v4 05/13] init: Call mem_encrypt_init() after Hyper-V hypercall init is done
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]