Re: [PATCH 2/3] powerpc/book3e: remove #include <generated/utsrelease.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Le 26/11/2022 à 15:07, Thomas Weißschuh a écrit :
> On 2022-11-26 07:36+0000, Christophe Leroy wrote:
>> Le 26/11/2022 à 06:10, Thomas Weißschuh a écrit :
>>> Commit 7ad4bd887d27 ("powerpc/book3e: get rid of #include <generated/compile.h>")
>>> removed the usage of the define UTS_VERSION but forgot to drop the
>>> include.
>>
>> What about:
>> arch/powerpc/platforms/52xx/efika.c
>> arch/powerpc/platforms/amigaone/setup.c
>> arch/powerpc/platforms/chrp/setup.c
>> arch/powerpc/platforms/powermac/bootx_init.c
>>
>> I believe you can do a lot more than what you did in your series.
> 
> The commit messages are wrong.
> They should have said UTS_RELEASE instead of UTS_VERSION.

Ah, ok. So your series is complete then:

$ git grep -L UTS_RELEASE `git grep -l "#include <generated/utsrelease.h>"`
Documentation/target/tcm_mod_builder.py
arch/powerpc/mm/nohash/kaslr_booke.c
drivers/base/firmware_loader/firmware.h
init/version.c

Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>

> 
> Could the maintainers fix this up when applying?
> I also changed it locally so it will be fixed for v2.
> 
>> List of files using UTS_VERSION :
>>
>> $ git grep -l UTS_VERSION
>> [..]
> 
> Thomas




[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux