On Mon, Oct 10, 2022, at 1:56 PM, Huacai Chen wrote: > Commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING > forcibly") allows compiler to uninline functions marked as 'inline'. > In case of __xchg()/__cmpxchg() this would cause to reference > BUILD_BUG(), which is an error case for catching bugs and will not > happen for correct code, if __xchg()/__cmpxchg() is inlined. > > This bug can be produced with CONFIG_DEBUG_SECTION_MISMATCH enabled, > and the solution is similar to below commits: > 46f1619500d0225 ("MIPS: include: Mark __xchg as __always_inline"), > 88356d09904bc60 ("MIPS: include: Mark __cmpxchg as __always_inline"). > > Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx> Looks good to me, Acked-by: Arnd Bergmann <arnd@xxxxxxxx>