Re: [PATCH v2 09/39] x86/mm: Move pmd_write(), pud_write() up in the file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>
Subject: Re: [PATCH v2 09/39] x86/mm: Move pmd_write(), pud_write() up in the file
From: Kees Cook <keescook@xxxxxxxxxxxx>
Date: Mon, 3 Oct 2022 11:06:19 -0700
Cc: x86@xxxxxxxxxx, "H . Peter Anvin" <hpa@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Balbir Singh <bsingharora@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Cyrill Gorcunov <gorcunov@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Eugene Syromiatnikov <esyr@xxxxxxxxxx>, Florian Weimer <fweimer@xxxxxxxxxx>, "H . J . Lu" <hjl.tools@xxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Mike Kravetz <mike.kravetz@xxxxxxxxxx>, Nadav Amit <nadav.amit@xxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, "Ravi V . Shankar" <ravi.v.shankar@xxxxxxxxx>, Weijiang Yang <weijiang.yang@xxxxxxxxx>, "Kirill A . Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, joao.moreira@xxxxxxxxx, John Allen <john.allen@xxxxxxx>, kcc@xxxxxxxxxx, eranian@xxxxxxxxxx, rppt@xxxxxxxxxx, jamorris@xxxxxxxxxxxxxxxxxxx, dethoma@xxxxxxxxxxxxx, Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>
In-reply-to: <20220929222936.14584-10-rick.p.edgecombe@intel.com>
References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-10-rick.p.edgecombe@intel.com>

On Thu, Sep 29, 2022 at 03:29:06PM -0700, Rick Edgecombe wrote:
> From: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>
> 
> To prepare the introduction of _PAGE_COW, move pmd_write() and
> pud_write() up in the file, so that they can be used by other
> helpers below.  No functional changes.
> 
> Signed-off-by: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>

Hey, a PTE patch I'm able to review! ;)

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

-- 
Kees Cook

References:
- [PATCH v2 00/39] Shadowstacks for userspace
  - From: Rick Edgecombe
- [PATCH v2 09/39] x86/mm: Move pmd_write(), pud_write() up in the file
  - From: Rick Edgecombe

Prev by Date: Re: [PATCH v2 07/39] x86/cet: Add user control-protection fault handler
Next by Date: Re: [PATCH v2 12/39] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY to _PAGE_COW
Previous by thread: [PATCH v2 09/39] x86/mm: Move pmd_write(), pud_write() up in the file
Next by thread: [PATCH v2 10/39] x86/mm: Introduce _PAGE_COW
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]