Hi Arnd, On Thu, Aug 18, 2022 at 12:28 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Thu, Aug 18, 2022 at 11:20 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > I'd like this applied to the alpha tree if there is such a > > thing otherwise maybe Arnd can apply it to the arch generic > > tree? > > Sure, I can do that. Could you apply this to the arch tree? I see no signs of life from the alpha maintainers. > > +/* > > + * These defines are necessary to use the generic io.h for filling in > > + * the missing parts of the API contract. This is because the platform > > + * uses (inline) functions rather than defines and the generic helper > > + * fills in the undefined. > > + */ > > +#define virt_to_phys virt_to_phys > > +#define phys_to_virt phys_to_virt > > +#define memset_io memset_io > > +#define memcpy_fromio memcpy_fromio > > We tend to have these next to the function definition rather than > in a single place. Again, I'm not too worried here, just if you end > up reworking the patch in some form, or doing the same for the > other architectures that would be the way to do it. I looked into this, for parisc it was pretty straight forward. alpha has a bunch of competing static inlines and externs and what not, I don't see it helping to inline this, IMO it's actually better like this: "those were defined somewhere in the birdnest of ifdefs above". If it is a big issue I can start to pry into it. Yours, Linus Walleij
