Hey Guo Ren, (off topic: is Guo or Ren your given name?) This series seems to introduce a build warning: arch/riscv/kernel/irq.c:17:1: warning: symbol 'irq_stack_ptr' was not declared. Should it be static? One more comment below: On 04/09/2022 08:26, guoren@xxxxxxxxxx wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx> > > The patches convert riscv to use the generic entry infrastructure from > kernel/entry/*. Add independent irq stacks (IRQ_STACKS) for percpu to > prevent kernel stack overflows. Add the HAVE_SOFTIRQ_ON_OWN_STACK > feature for the IRQ_STACKS config. You can try it directly with [1]. > > [1] https://github.com/guoren83/linux/tree/generic_entry_v2 > > Changes in V2: > - Fixup compile error by include "riscv: ptrace: Remove duplicate > operation" > https://lore.kernel.org/linux-riscv/20220903162328.1952477-2-guoren@xxxxxxxxxx/T/#u I find this really confusing. The same patch is in two different series? Is the above series no longer required & this is a different approach? Thanks, Conor. > - Fixup compile warning > Reported-by: kernel test robot <lkp@xxxxxxxxx> > - Add test repo link in cover letter > > Guo Ren (6): > riscv: ptrace: Remove duplicate operation > riscv: convert to generic entry > riscv: Support HAVE_IRQ_EXIT_ON_IRQ_STACK > riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK > riscv: elf_kexec: Fixup compile warning > riscv: compat_syscall_table: Fixup compile warning > > arch/riscv/Kconfig | 10 + > arch/riscv/include/asm/csr.h | 1 - > arch/riscv/include/asm/entry-common.h | 8 + > arch/riscv/include/asm/irq.h | 3 + > arch/riscv/include/asm/ptrace.h | 10 +- > arch/riscv/include/asm/stacktrace.h | 5 + > arch/riscv/include/asm/syscall.h | 6 + > arch/riscv/include/asm/thread_info.h | 15 +- > arch/riscv/include/asm/vmap_stack.h | 28 +++ > arch/riscv/kernel/Makefile | 1 + > arch/riscv/kernel/elf_kexec.c | 4 + > arch/riscv/kernel/entry.S | 255 +++++--------------------- > arch/riscv/kernel/irq.c | 75 ++++++++ > arch/riscv/kernel/ptrace.c | 41 ----- > arch/riscv/kernel/signal.c | 21 +-- > arch/riscv/kernel/sys_riscv.c | 26 +++ > arch/riscv/kernel/traps.c | 11 ++ > arch/riscv/mm/fault.c | 12 +- > 18 files changed, 250 insertions(+), 282 deletions(-) > create mode 100644 arch/riscv/include/asm/entry-common.h > create mode 100644 arch/riscv/include/asm/vmap_stack.h > > -- > 2.36.1 >
