On Tue, Aug 30, 2022 at 9:58 AM Davide Ciminaghi <ciminaghi@xxxxxxxxx> wrote: > the sta2x11 was a chip containing AMBA peripherals and a PCIe to AMBA bridge > (it is still in production as far as I know, but deprecated for new designs). > It would typically be installed on x86 machines, so you needed to build and > run AMBA drivers in an x86 environment. The original drivers we started from > had platform data, but then we were told to switch to DTS. For the record I think that was bad advice, I hope it wasn't me. But the world was different back then I suppose. Adding DTS to x86 which is inherently ACPI is not a good idea. Especially if you look at how SBSA ACPI UARTS were done in drivers/tty/serial/amba-pl011.c. Today I think we would solve this by simply creating software nodes, which are the same no matter if you're doing device tree or ACPI, so it would have been much easier now, I think. :/ Yours, Linus Walleij