On Fri, Aug 26, 2022 at 4:10 PM Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > Looks good to me, except I'd just do > > #define arch_test_bit_acquire arch_test_bit > > on hexagon rather than duplicate that function. Oh, except you didn't quite duplicate it, you added the "memory" clober to it to make sure it's ordered. Which looks correct to me, even if the "almost entirely duplicated" is a bit annoying. Linus