Re: [PATCH v2] arch/cacheflush: Introduce flush_all_caches()

[Davidlohr Bueso <dave@xxxxxxxxxxxx>]

On Fri, 19 Aug 2022, Ira Weiny wrote:

> Did you mean "must"?

Yep.

> > + * such as those which caches are in a consistent state. The
> > + * caller can verify the situation early on.
> > + */
> > +#ifndef flush_all_caches
> > +# define flush_all_caches_capable() false
> > +static inline void flush_all_caches(void)
> > +{
> > +	WARN_ON_ONCE("cache invalidation required\n");
> > +}
>
> With the addition of flush_all_caches_capable() will flush_all_caches() ever be
> called?

No, it should not. Hence you get a splat if you call it bogusly.